86 Commits

Include renames

• deploy/synology_dsm.sh: use grep -Eo '[0-9]+' when extracting error codes

  grep -o '[0-9]*' can match the empty string; GNU grep skips empty
  matches but BSD greps handle them differently, breaking the 2FA
  login flow on OpenBSD. Force a non-empty match at all three sites.
  
  from https://github.com/acmesh-official/acme.sh/pull/6725

  neil 2026-07-10 18:37:32 +08:00
  660a5e322c
• Fix typo (#6924)
  Jan Pieper 2026-07-10 14:42:57 +08:00
  2af543a358
• Add _cleardeployconf to clear deploy hook keys from domain conf

  Mirrors _clearaccountconf_mutable: clears the SAVED_ prefixed key and
  the legacy unprefixed key. Replaces the local copy in synology_dsm.sh
  and the direct _cleardomainconf call in multideploy.sh.
  
  Closes #4722. Thanks to @sg1888.

  neil 2026-07-10 11:05:40 +08:00
  45c0ad4112
• https://github.com/acmesh-official/acme.sh/issues/3201
  neil 2026-07-04 16:55:49 +08:00
  1a36823461
• Fix typo in synology_dsm.sh (#6406)

  Fix typo in an error message.

  Artur Klauser 2026-07-04 00:32:45 +08:00
  2229330c48
• Don't mark restart http as failed if json returns false because it was not restarted (#6906)
  Mitchell van Bijleveld 2026-04-14 20:37:50 +08:00
  f3e61a8ef4
• Update synology_dsm.sh (#6894)

  quote variable name so message isn't missing the variable that needs to be fixed.
  this was reported in #2727  (feedback for hook)

  Florian Heigl 2026-04-03 11:38:21 +08:00
  ef49a9fd23
• chore(synology): remove personal mail
  Scruel Tao 2025-02-20 17:16:23 +08:00
  091c1f7ef1
• Update synology_dsm.sh

  fix check logic

  David Ha 2025-02-09 23:43:55 +00:00
  899da0c6ea
• Fix bug saving SYNO_LOCAL_HOSTNAME

  Exporting SYNO_LOCAL_HOSTNAME=1 only works on the first deploy invocation. Subsequent deploys using the saved config fails because it saves $SYNO_HOSTNAME instead of $SYNO_LOCAL_HOSTNAME.

  David Ha 2025-02-09 22:56:46 +00:00
  def41a7878
• fix format
  neil 2024-09-15 14:30:12 +02:00
  2d282597ca
• Merge pull request #5139 from scruel/scruel-patch-1

  feat: guide user to run script as root to create temp admin user

  neil 2024-07-19 11:16:44 +08:00
  11aef82993
• fix(deploy): respect api path with synology Auth API

  fix #5184

  Scruel Tao 2024-07-14 15:04:43 +08:00
  60569fdd83
• chore: optimize more msgs
  Scruel Tao 2024-05-08 14:01:43 +08:00
  1dbc58d4e0
• chore: typo
  Scruel Tao 2024-05-08 04:46:51 +08:00
  47ccb28482
• feat: guide user to run script as root to create temp admin user

  Message text and comment optimized

  Scruel Tao 2024-05-08 02:56:21 +08:00
  744dea00ca
• fix(deploy_dsm): ensure grep get the error code

  Added grep -o option to ensure the script won't get other digits as the error code result

  Scruel Tao 2024-04-25 13:39:05 +08:00
  cd01104de9
• fix(deploy_dsm): missing gerp -P option on busybox

  Fixes:  #5105

  Scruel Tao 2024-04-25 04:02:49 +08:00
  9ff89b570f
• doc: adjust
  Scruel Tao 2024-02-28 02:00:07 +08:00
  6af5293315
• fix lint
  Scruel Tao 2024-02-26 23:45:19 +08:00
  ff090d2f74
• feat: improve robustness of the usage of DSM tool synogroup
  Scruel Tao 2024-02-26 23:38:44 +08:00
  68e3a12a91
• fix: lint
  Scruel Tao 2024-02-26 21:07:15 +08:00
  50eda6b678
• feat: add SYNO_LOCAL_HOSTNAME to prevent remote deploy via temp admin method
  Scruel Tao 2024-02-26 21:03:26 +08:00
  192ec598a3
• refactor: unify variable naming convention again (revert some changes)
  Scruel Tao 2024-02-26 20:55:49 +08:00
  5b449999a5
• fix: should save SYNO_UseTempAdmin only after login success.
  Scruel Tao 2024-02-26 07:05:00 +08:00
  afed62f6de
• feat: bypass enforce temp admin 2FA
  Scruel Tao 2024-02-26 06:23:47 +08:00
  59d1e16f9c
• feat: more user-friendly logic & error messages.
  Scruel Tao 2024-02-26 06:23:46 +08:00
  dbe0d477d6
• feat: support DSM 6.x
  Scruel Tao 2024-02-26 06:23:45 +08:00
  7248560169
• refactor: unify variable naming convention
  Scruel Tao 2024-02-26 06:23:42 +08:00
  f840f7d75b
• doc(deploy): update usage doc
  Scruel Tao 2024-02-22 12:38:51 +08:00
  cf3839ecec
• Merge pull request #4706 from scruel/syno-patch

  Add SYNO_USE_TEMP_ADMIN variable & Fix broken logic

  neil 2024-02-13 09:57:51 +08:00
  aa8cf76fb1
• Update synology_dsm.sh
  LordDarkneo 2023-12-22 14:36:52 -05:00
  6992659ba9
• Update synology_dsm.sh

  #2727 issue when logging out on older version - using variables to unlog only for CERT user

  LordDarkneo 2023-12-22 14:34:35 -05:00
  05696d443a
• Update synology_dsm.sh

  Issue for lougout

  LordDarkneo 2023-12-22 09:09:29 -05:00
  f59a925897
• fix: Synology DSM API path regex

  Fix the regex for looking up the API path value from the Synology API query.

  Romeo Dumitrescu 2023-09-25 18:43:01 +03:00
  87a7bde618
• Optimze comment & remove tail space
  Scruel Tao 2023-09-07 15:01:37 +08:00
  29b2960805
• Merge branch 'dev' into syno-patch
  Scruel Tao 2023-09-07 14:57:53 +08:00
  f7f3a0bf0d
• Fix device ID property name for DSM 6
  Martin Arndt 2023-08-11 17:55:45 +02:00
  b793dbf977
• Fix Auth API access for DSM 6
  Martin Arndt 2023-08-09 19:52:37 +02:00
  d52b38777a
• Fix for shfmt check
  Scruel Tao 2023-07-20 13:38:36 +08:00
  ba468bb5e4
• Fix for shfmt check
  Scruel Tao 2023-07-20 13:34:57 +08:00
  cf86d57a9f
• Fix shellcheck
  Scruel Tao 2023-07-20 13:09:21 +08:00
  9e958f4e32
• Add SYNO_USE_TEMP_ADMIN variable & Fix broken logic

  1. Fix the broken logic in (Sorry for including fix commit in same PR, I'm feeling quite tired and would like to go to sleep right away...)
  2. Provides new method to obtain credential info for authentication, it will create a temp admin user if SYNO_USE_TEMP_ADMIN is set, instead of requiring the user's own credentials which will be saved in disk.
  
  I do really don't like to have plaintext credentials be saved in disk, and I noticed that you've spent a lot of time fighting with 2FA related stuffs, so why not just get rid of the whole old way. :)

  Scruel Tao 2023-07-20 02:48:29 +08:00
  c7f6f20c9d
• Fix variable initialization
  Martin Arndt 2023-07-04 16:58:14 +02:00
  0d7b831661
• Update synology_dsm.sh

  Split "[ && ]" into "[ ] && [ ]" to make ShellCheck happy

  Martin Arndt 2023-07-04 15:55:44 +02:00
  0c9e4f67a8
• Re-add deprecated SYNO_TOTP_SECRET part for legacy compatibility

  As requested in acmesh-official/acme.sh/pull/4646 by Neil Pang

  Martin Arndt 2023-07-04 15:47:19 +02:00
  db3f131dfc
• Fix debug output of session ID
  Martin Arndt 2023-05-28 22:33:15 +02:00
  0548ad2fc6
• Remove external OTP dependency from synology_dsm.sh

  Also adapt to DSM 7's API improvements.

  Martin Arndt 2023-05-28 21:42:53 +02:00
  623d615cd7
• fix(deploy-synology_dsm): support DID with DSM 7
  Markus Lippert 2022-09-29 12:22:45 +02:00
  a7dd86de71
• Update return statement
  John Elliott 2022-02-07 21:55:12 -08:00
  3a99a77104